[wesnoth-commits] [wesnoth/wesnoth] a99ec5: gui2/addon_manager: Re-read add-on versions after ...

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a99ec54accbbdbd8cd312ae549b5e9d26e1fa3bc
      https://github.com/wesnoth/wesnoth/commit/a99ec54accbbdbd8cd312ae549b5e9d26e1fa3bc
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-03-14 (Sat, 14 Mar 2020)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  gui2/addon_manager: Re-read add-on versions after each update batch

The Update All codepath is unique in that it doesn't trigger a re-read
of add-on versions until the very end, once the full run has completed.
The problem with this is that install_addon_with_checks() may update
dependencies of individual add-ons in the process, resulting in
redundant downloads of any affected add-ons if the player isn't paying
attention.

Address this by triggering a re-read of add-on versions after every
single update batch that results in a download.

Closes #3273.


  Commit: e92ee3993294116ee3040982b4a25e28e600881a
      https://github.com/wesnoth/wesnoth/commit/e92ee3993294116ee3040982b4a25e28e600881a
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-03-15 (Sun, 15 Mar 2020)

  Changed paths:
    M changelog.md
    M data/campaigns/Delfadors_Memoirs/maps/14_Shadows_in_the_Dark.map
    M data/campaigns/Delfadors_Memoirs/maps/15_Save_the_King.map
    M data/campaigns/Delfadors_Memoirs/maps/18_The_Portal_of_Doom.map
    M data/campaigns/Delfadors_Memoirs/maps/19_Showdown_in_the_Northern_Swamp.map
    M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
    M data/core/units/dunefolk/Alchemist.cfg
    M data/core/units/dunefolk/Apothecary.cfg
    M data/core/units/dunefolk/Blademaster.cfg
    M data/core/units/dunefolk/Burner.cfg
    M data/core/units/dunefolk/Captain.cfg
    M data/core/units/dunefolk/Explorer.cfg
    M data/core/units/dunefolk/Firetrooper.cfg
    M data/core/units/dunefolk/Herbalist.cfg
    M data/core/units/dunefolk/Luminary.cfg
    M data/core/units/dunefolk/Paragon.cfg
    M data/core/units/dunefolk/Rover.cfg
    M data/core/units/dunefolk/Scorcher.cfg
    M data/core/units/dunefolk/Soldier.cfg
    M data/core/units/dunefolk/Spearguard.cfg
    M data/core/units/dunefolk/Spearmaster.cfg
    M data/core/units/dunefolk/Swordsman.cfg
    M data/core/units/dunefolk/Warmaster.cfg
    M data/core/units/dunefolk/Wayfarer.cfg
    M projectfiles/VC16/wesnothd.vcxproj
    M src/ai/formula/candidates.cpp
    M src/server/game.cpp
    M src/server/server.cpp
    M src/units/frame.cpp
    M src/units/unit.cpp
    M utils/travis/steps/install.sh
    M utils/travis/steps/script.sh

  Log Message:
  -----------
  Merge branch 'master' into bug/3273


  Commit: 64a96d2eba0693a53806469f16b2f94a4e36d8ff
      https://github.com/wesnoth/wesnoth/commit/64a96d2eba0693a53806469f16b2f94a4e36d8ff
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-03-15 (Sun, 15 Mar 2020)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Merge pull request #4802 from shikadiqueen/bug/3273

gui2/addon_manager: Re-read add-on versions after each update batch


Compare: https://github.com/wesnoth/wesnoth/compare/3e4c63a69899...64a96d2eba06