[wesnoth-commits] [wesnoth/wesnoth] 296046: SotA: Don't concatenate strings in the recruit dialog

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 296046d211ff74c7b23c7026420cdc52c79ec2bd
      https://github.com/wesnoth/wesnoth/commit/296046d211ff74c7b23c7026420cdc52c79ec2bd
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/units/SotA_Corpses.cfg
    M data/campaigns/Secrets_of_the_Ancients/utils/zombie-utils.cfg
    M data/campaigns/Secrets_of_the_Ancients/utils/zombie_recruit_dialog.lua

  Log Message:
  -----------
  SotA: Don't concatenate strings in the recruit dialog

Instead of trying to concatenate translatable strings, just make a single full
string to be shown in the recruitment dialog. This came from trying to update
the i18n hints, and realising my suggest of making the swimmers "Merfolk" in
f6dc83375 was causing problems when they could also be nagas.

These strings are stored in a variable at the start of the campaign (in
ZOMBIE_INIT), so won't appear when loading an existing save game. This is why
the Lua script keeps some support for the old names (although they're not going
to be translated in that case).