[wesnoth-commits] [wesnoth/wesnoth] 3f93c2: Improve user-friendliness of the validation options

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3f93c263a901ca68316a1b66bd0b96c588ab9f3f
      https://github.com/wesnoth/wesnoth/commit/3f93c263a901ca68316a1b66bd0b96c588ab9f3f
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp
    M src/game_config_manager.cpp

  Log Message:
  -----------
  Improve user-friendliness of the validation options

* Fixes #4223, by making the --validate and --validate-* options imply --nocache.

* Fixes #4224, showing an error if you misspell the id argument to
  --validate-addon. The application doesn't (but should) quit automatically to
  avoid the user spending time on a non-functional validation run, however it
  does at least disable all add-ons, which should have the same end result.

* Shows a warning that --validate-addon needs the user to play the add-on, it
  doesn't automatically check the add-on. This was my misunderstanding when
  logging issue #4225, which has now been repurposed into a feature request for
  a new tool that does what I thought --validate-addon did.