[wesnoth-commits] [wesnoth/wesnoth] cb867c: log/windows: Fix missing class member initializer

[Iris Morelle]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cb867c0c2dc15e670d56c33c84331913b1d34528
      https://github.com/wesnoth/wesnoth/commit/cb867c0c2dc15e670d56c33c84331913b1d34528
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M changelog.md
    M src/log_windows.cpp

  Log Message:
  -----------
  log/windows: Fix missing class member initializer

This had the confusing side-effect of making some code in wesnoth.cpp
believe it was safe to prompt the user to press Enter when NOT using
--wconsole on my system, because the flag ended up with a true value by
default.

This is why you don't leave integral-type variables uninitialized, ever.


  Commit: 7c9bd06ee4340952968f0f98d54f1a68ea7235ae
      https://github.com/wesnoth/wesnoth/commit/7c9bd06ee4340952968f0f98d54f1a68ea7235ae
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M src/log_windows.cpp

  Log Message:
  -----------
  log/windows: Guard against null pointer dereference

This is semantically correct since we can't claim we own a console
before we find out if we have one or need to set one up.

Nobody should be calling using_own_console() before
early_log_file_setup() finishes, but you never know. People in this
project have surprised me before.


  Commit: 3c39c6b26825dff0e490f3a41def659301adb7a2
      https://github.com/wesnoth/wesnoth/commit/3c39c6b26825dff0e490f3a41def659301adb7a2
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M doc/man/wesnoth.6
    M src/commandline_options.cpp

  Log Message:
  -----------
  Minor fixes to --help text

More importantly, --log-precise's description is now more
platform-agnostic (there isn't a "logfile" on platforms other than
Windows).


  Commit: 5b64bd1f026c17c8be266d84919e594e31a44580
      https://github.com/wesnoth/wesnoth/commit/5b64bd1f026c17c8be266d84919e594e31a44580
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M doc/man/wesnoth.6
    M src/commandline_options.cpp

  Log Message:
  -----------
  Remove network proxy-related command line option descriptions

The command line options themselves were removed in commit
168313bed9da570d3bf7d4b6bc7fc93db1e7935f, wherein someone clearly didn't
do the full research.

Specifically, the SDL_net-based implementation of the network API never
supported or used these options. Only libana did.


  Commit: 0f465fc60747424e2b92428a81f5f43c97504088
      https://github.com/wesnoth/wesnoth/commit/0f465fc60747424e2b92428a81f5f43c97504088
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M src/commandline_options.hpp

  Log Message:
  -----------
  Fix indentation


  Commit: 556f6d073bf17cc15dfbe80cb2bc8b0b12a05b55
      https://github.com/wesnoth/wesnoth/commit/556f6d073bf17cc15dfbe80cb2bc8b0b12a05b55
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  Update changelog

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/4abeef29d4d1...556f6d073bf1