[wesnoth-commits] [wesnoth/wesnoth] 303d2e: Allow the player to recruit, even when some recrui...

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 303d2eee77c6061f904ffe8e4ba2c607fad0ee13
      https://github.com/wesnoth/wesnoth/commit/303d2eee77c6061f904ffe8e4ba2c607fad0ee13
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-09-12 (Sat, 12 Sep 2020)

  Changed paths:
    M src/menu_events.cpp

  Log Message:
  -----------
  Allow the player to recruit, even when some recruitable units aren't known (#5146)

Fixes #5144 "one missing unit in recruit list makes entire recruit list
unavailable". The player will see an error dialog every time they try to
recruit, that seems good given that the limited recruitment options are likely
to severely affect game balance.

The `std::vector<t_string> unknown_units` uses t_string instead of std::string
because that's the class needed for format_conjunct_list. Those items aren't
translated - they're the values of [unit_type]id=, but the corresponding
[unit_type] is missing, so we can't get the translatable [unit_type]name=.