[wesnoth-commits] [wesnoth/wesnoth] b8b06d: Make WFL's error-reporting machinery thread_local

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b8b06d086244177d7c3f8ece3f73a7ea9e66f424
      https://github.com/wesnoth/wesnoth/commit/b8b06d086244177d7c3f8ece3f73a7ea9e66f424
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-03-29 (Mon, 29 Mar 2021)

  Changed paths:
    M changelog.md
    M src/formula/function.cpp
    M src/formula/function.hpp

  Log Message:
  -----------
  Make WFL's error-reporting machinery thread_local

To report the WFL call stack in the event of errors, a static stack is used to
record that call-stack. This wasn't thread-safe, and it intermittently crashed
when the game config was movetype patching (the other WFL thread involved is
the GUI2 layout code).

Also a Rule of Three fix for the call_stack_manager class. While this wasn't
the cause of the crash, it could also have lead to a call_stack.pop_back() on
an empty stack.


  Commit: 289ac354a07b2d5ac05481e5e949eae5505190cd
      https://github.com/wesnoth/wesnoth/commit/289ac354a07b2d5ac05481e5e949eae5505190cd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M changelog.md
    M src/formula/function.cpp
    M src/formula/function.hpp

  Log Message:
  -----------
  Merge pull request #5646 from stevecotton/wfl_error_thread_master

[1.15] Make WFL's error-reporting machinery thread_local


Compare: https://github.com/wesnoth/wesnoth/compare/ea46abf5b0ee...289ac354a07b