[wesnoth-commits] [wesnoth/wesnoth] 9f8a19: Simplify canvas.cpp: the renderer only needs to ex...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9f8a19e6a70a75674a2ce6b3439c9134d61cb0a3
      https://github.com/wesnoth/wesnoth/commit/9f8a19e6a70a75674a2ce6b3439c9134d61cb0a3
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-04-11 (Sun, 11 Apr 2021)

  Changed paths:
    M src/gui/core/canvas.cpp
    M src/gui/core/canvas.hpp

  Log Message:
  -----------
  Simplify canvas.cpp: the renderer only needs to exist during draw()

The renderer only needs to exist during draw(). The old implementation kept the
old renderer until the next call to draw(), but would then usually destroy the
old one and create a new one.


  Commit: 362eebc6f047a2e93c9dbe7f09eb29f57b8288bc
      https://github.com/wesnoth/wesnoth/commit/362eebc6f047a2e93c9dbe7f09eb29f57b8288bc
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-04-11 (Sun, 11 Apr 2021)

  Changed paths:
    M src/gui/core/canvas.cpp
    M src/gui/core/canvas.hpp

  Log Message:
  -----------
  Simplify canvas.cpp: only one list of shapes, not shared

Canvas kept separate lists of what had already been drawn and what needed to be
drawn, but whenever changes happened all of the drawn_shapes_ were put back
into shapes_. No point in having two separate lists.

The list of shape needs pointers to support polymorphism, but doesn't need
shared_ptrs.


  Commit: 35348ff24642849a7351e79fe75d0542e6986731
      https://github.com/wesnoth/wesnoth/commit/35348ff24642849a7351e79fe75d0542e6986731
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-04-14 (Wed, 14 Apr 2021)

  Changed paths:
    M src/gui/core/canvas.cpp
    M src/gui/core/canvas.hpp

  Log Message:
  -----------
  Merge pull request #5697 from stevecotton/simplify_canvas

Simplify canvas: renderer lifetime and only one list of shapes


Compare: https://github.com/wesnoth/wesnoth/compare/c72ea20c99e1...35348ff24642