[wesnoth-commits] [wesnoth/wesnoth] 64d3fa: Make the log_domain constructor explicit

Celtic Minstrel noreply at github.com
Fri Apr 16 03:16:40 UTC 2021


  Branch: refs/heads/lua_events
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 64d3fa11d0526748d633df11d973d51153bb0702
      https://github.com/wesnoth/wesnoth/commit/64d3fa11d0526748d633df11d973d51153bb0702
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M src/deprecation.cpp
    M src/game_events/manager_impl.cpp
    M src/game_events/pump.cpp
    M src/log.hpp
    M src/whiteboard/manager.cpp

  Log Message:
  -----------
  Make the log_domain constructor explicit

Implicitly constructing a log_domain from a string has the effect of resetting its severity to 1 (or whatever severity was passed to the constructor). This is probably fine when it's declared as a file static, but no good if passing the log_domain to a log_scope2() or dont_log() call.


  Commit: 989133af4795a7c653f834f4debce1f82d95f588
      https://github.com/wesnoth/wesnoth/commit/989133af4795a7c653f834f4debce1f82d95f588
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M src/game_events/handlers.hpp
    M src/game_events/manager.cpp

  Log Message:
  -----------
  Some logging


  Commit: b3f311e0d68ba836b4d5c18398fee83a959fe5d6
      https://github.com/wesnoth/wesnoth/commit/b3f311e0d68ba836b4d5c18398fee83a959fe5d6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M data/lua/wml-tags.lua

  Log Message:
  -----------
  Fix delayed_variable_substitution defaulting to false


  Commit: b6e86862de3e26a87b190db5e4e9ef15c5387100
      https://github.com/wesnoth/wesnoth/commit/b6e86862de3e26a87b190db5e4e9ef15c5387100
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M run_wml_tests

  Log Message:
  -----------
  run_wml_tests: Fix off-by-one error in 1285060bc480b8568f6312ff2753a0645ebd0187


  Commit: 572a22e6604cb453a72536b1ba724e8812b7d25a
      https://github.com/wesnoth/wesnoth/commit/572a22e6604cb453a72536b1ba724e8812b7d25a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M run_wml_tests

  Log Message:
  -----------
  run_wml_tests: Fix exit code


  Commit: e2dfc58189e0baf9166f03eeba917e1d6278454c
      https://github.com/wesnoth/wesnoth/commit/e2dfc58189e0baf9166f03eeba917e1d6278454c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M run_wml_tests

  Log Message:
  -----------
  run_wml_tests: Show negative test summary values

These values should never BE negative, but by showing them if they are, it makes it more obvious if something is broken.


  Commit: 7f731cb31043c72e627d4dde3c6f72997355bd6b
      https://github.com/wesnoth/wesnoth/commit/7f731cb31043c72e627d4dde3c6f72997355bd6b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-04-15 (Thu, 15 Apr 2021)

  Changed paths:
    M src/game_events/manager.cpp

  Log Message:
  -----------
  missing space in a log message


Compare: https://github.com/wesnoth/wesnoth/compare/f3768fbc232f...7f731cb31043



More information about the Commits mailing list