[wesnoth-commits] [wesnoth/wesnoth] 53f9db: Remove the Delay Advancements modification.

[Pentarctagon]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 53f9dbb51a2fcae9ffb616c91026de33e4f5913d
      https://github.com/wesnoth/wesnoth/commit/53f9dbb51a2fcae9ffb616c91026de33e4f5913d
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
    M data/modifications.cfg
    M src/play_controller.cpp
    M src/units/helper.cpp

  Log Message:
  -----------
  Remove the Delay Advancements modification.

While implementationally it's very simple, the feedback so far (minimal as it may be) has been negative due to the side effects on existing gameplay mechanics:
* Delaying advancement until the next time it's the advancing unit's side's turn gives enemies a much larger window to kill the unit to prevent it from leveling up.
* The majority of units don't have multiple advancement options, so delaying their advancement as well isn't helpful.

Additionally, leaving this in for 1.16 would mean that it would not be possible to remove it in 1.17 or later without breaking any replays that did use it.


  Commit: c05e39ecc1d10b66b380b93bc46e2da14e36c021
      https://github.com/wesnoth/wesnoth/commit/c05e39ecc1d10b66b380b93bc46e2da14e36c021
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
    M src/actions/advancement.cpp

  Log Message:
  -----------
  Always have units with multiple advancements level up to the first one listed in the unit_type.

There's already enough randomness in Wesnoth; having the game randomly choose what a unit levels up to in a multiplayer game because it happens to advance on someone else's turn is unnecessary.
This also reduces the need to manually select a unit's advancement path for advancement planning modifications. For example, if you want your Mage to level up into a White Mage, this is now the default and doesn't need to be manually selected by the player.


  Commit: 093db78cc73b4ade5c186298f31997877a69ccd6
      https://github.com/wesnoth/wesnoth/commit/093db78cc73b4ade5c186298f31997877a69ccd6
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
    M data/core/_main.cfg
    A data/lua/as_text.lua
    M data/modifications.cfg
    A data/modifications/pick_advance/README.md
    A data/modifications/pick_advance/dialog.lua
    A data/modifications/pick_advance/main.lua
    A data/test/scenarios/as_text.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Add the Plan Unit Advance modification to mainline.


Compare: https://github.com/wesnoth/wesnoth/compare/bbcf9db1b512...093db78cc73b