[wesnoth-commits] [wesnoth/wesnoth] d666cc: Need this to avoid missing return error

[Celtic Minstrel]

  Branch: refs/heads/lua_gamemap
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d666cc1f64dafd156613cadf55f0fe6d9340a685
      https://github.com/wesnoth/wesnoth/commit/d666cc1f64dafd156613cadf55f0fe6d9340a685
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M src/scripting/lua_terrainmap.cpp

  Log Message:
  -----------
  Need this to avoid missing return error


  Commit: 14fbc4cc8a8de4cb090b5f00346697a261f0cd46
      https://github.com/wesnoth/wesnoth/commit/14fbc4cc8a8de4cb090b5f00346697a261f0cd46
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M data/lua/core.lua
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_terrainmap.cpp
    M src/scripting/lua_terrainmap.hpp

  Log Message:
  -----------
  Move replace_if_failed function to correct location


  Commit: 28da1894a3bf8d5ac4820f23d6417d5434e06dcb
      https://github.com/wesnoth/wesnoth/commit/28da1894a3bf8d5ac4820f23d6417d5434e06dcb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M data/lua/core.lua
    M src/scripting/lua_terrainmap.cpp

  Log Message:
  -----------
  Add a separate getter pair for playable height and width


  Commit: fcafa9617e1a2b4e0f686fd1b24c98212f2ba39c
      https://github.com/wesnoth/wesnoth/commit/fcafa9617e1a2b4e0f686fd1b24c98212f2ba39c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M src/scripting/lua_terrainmap.cpp

  Log Message:
  -----------
  Implement a map iterator


  Commit: d0d4cb9bfabc0283877504aba0d26366c509ff54
      https://github.com/wesnoth/wesnoth/commit/d0d4cb9bfabc0283877504aba0d26366c509ff54
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M src/scripting/lua_terrainmap.cpp

  Log Message:
  -----------
  Add an on_border function to the map metatable


  Commit: 3d1c7327642a50c7276511a7078c5eafe9284ad0
      https://github.com/wesnoth/wesnoth/commit/3d1c7327642a50c7276511a7078c5eafe9284ad0
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M data/ai/lua/ai_helper.lua
    M data/ai/lua/generic_recruit_engine.lua
    M data/ai/micro_ais/cas/ca_bottleneck_move.lua
    M data/ai/micro_ais/cas/ca_forest_animals_new_rabbit.lua
    M data/ai/micro_ais/cas/ca_recruit_random.lua
    M data/ai/micro_ais/cas/ca_wolves_move.lua
    M data/campaigns/Eastern_Invasion/ai/ca_ogres_flee.lua
    M data/lua/helper.lua
    M data/lua/location_set.lua
    M data/lua/wml-tags.lua
    M data/lua/wml/find_path.lua
    M data/modifications/pick_advance/main.lua

  Log Message:
  -----------
  Replace uses of get_map_size

Nearly all of these are replaced with either the iterator or an on_board call.
Only a few cases really needed to know the size of the map for some other purpose.


Compare: https://github.com/wesnoth/wesnoth/compare/3f1beb8b12fb...3d1c7327642a