[wesnoth-commits] [wesnoth/wesnoth] 4e5eb4: wc: WoCopedia UI cleanup pass #1

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4e5eb49a4aa999ef4a531c725e2b4532b4c47d37
      https://github.com/wesnoth/wesnoth/commit/4e5eb49a4aa999ef4a531c725e2b4532b4c47d37
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M data/campaigns/World_Conquest/lua/game_mechanics/wocopedia/help.lua
    M data/campaigns/World_Conquest/lua/game_mechanics/wocopedia/help_dialog.lua

  Log Message:
  -----------
  wc: WoCopedia UI cleanup pass #1

Still a lot of work left to do, but this initial commit focuses on
bringing the UI layout on par with mainline standards.

Notable remaining layout issues:

 * Training pages don't have a proper caption.

 * The Items page (previously Artifacts, relabeled Items for consistency
   with the rest of the help text) has individual items grow the list
   horizontally out of the page's bounds, resulting in a horizontal
   scrollbar on the item list right now, or one on the whole window if
   anything is done to prevent the former. There is currently no simple
   way to fix this since labels in listboxes and treeviews grow
   unchecked, rendering `wrap = true` moot.

 * The Factions page seems to be designed to display a list of factions
   but this doesn't seem to be used or working right now?

 * The Settings page has some evidence of this having been user-made
   content. We probably want to do away with some of it in mainline.
   Maybe.

 * The Feedback page screams UMC all over. It is also a bit useless
   without gfgtdf around right now...

 * Lots of questionable English or UI language around still.

 * I don't like tree views.