[wesnoth-commits] [wesnoth/wesnoth] 8f8976: Refactored out preferences::is_authenticated and f...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8f8976ff3ac7858ec475dca6db355fad06c9b55c
      https://github.com/wesnoth/wesnoth/commit/8f8976ff3ac7858ec475dca6db355fad06c9b55c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/chat_command_handler.cpp
    M src/display_chat_manager.cpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/multiplayer.hpp
    M src/gui/dialogs/multiplayer/player_info.cpp
    M src/gui/widgets/chatbox.cpp
    M src/menu_events.cpp
    M src/preferences/game.cpp
    M src/preferences/game.hpp

  Log Message:
  -----------
  Refactored out preferences::is_authenticated and friends

This moves all the is-autenticated (really is-moderator) stuff out of preferences and into a new session_metadata class.
Note this does remove the ability to [de]auth as a mod while logged in for now.

This also makes open_connection a member of mp_manager and splits some implementations out from their declarations.


  Commit: 3dba789518e33221bcbf19dac34db628db7767d6
      https://github.com/wesnoth/wesnoth/commit/3dba789518e33221bcbf19dac34db628db7767d6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/game_initialization/connect_engine.hpp
    M src/game_initialization/create_engine.hpp
    M src/game_initialization/flg_manager.hpp
    M src/server/common/simple_wml.hpp
    M src/server/wesnothd/game.hpp
    M src/units/types.hpp

  Log Message:
  -----------
  Used standard definitions for deleted copy constructors


  Commit: 86cf7478f494b8b33c8987ce652904ce439f342a
      https://github.com/wesnoth/wesnoth/commit/86cf7478f494b8b33c8987ce652904ce439f342a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  MP Manager: flagged `enter_*_mode` functions as const as appropriate


  Commit: 740e94c1abdcc18c55a41c96a53dcf54bea7aa32
      https://github.com/wesnoth/wesnoth/commit/740e94c1abdcc18c55a41c96a53dcf54bea7aa32
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  MP Manager: fixed crash when dismissing password prompt

I wasn't properly accounting for the cases where open_connection returns a nullptr.


  Commit: bd8b5be3fe9e4de0cfe13bac559c53bb7461e884
      https://github.com/wesnoth/wesnoth/commit/bd8b5be3fe9e4de0cfe13bac559c53bb7461e884
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/game_state.cpp

  Log Message:
  -----------
  Game State: formatted constructors


Compare: https://github.com/wesnoth/wesnoth/compare/24167931748f...bd8b5be3fe9e