[wesnoth-commits] [wesnoth/wesnoth] ba55d3: Forum User Handler: removed excess level of indent

Charles Dang noreply at github.com
Sat Jan 2 10:46:13 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ba55d3823c0a4d3c5fc21923ac36b775eece4319
      https://github.com/wesnoth/wesnoth/commit/ba55d3823c0a4d3c5fc21923ac36b775eece4319
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/server/common/forum_user_handler.hpp

  Log Message:
  -----------
  Forum User Handler: removed excess level of indent


  Commit: 75e9d8a0f1eb22b25a0c85640ac5b754b71d4c4e
      https://github.com/wesnoth/wesnoth/commit/75e9d8a0f1eb22b25a0c85640ac5b754b71d4c4e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M src/editor/map/context_manager.cpp
    M src/editor/map/editor_map.cpp
    M src/editor/map/editor_map.hpp
    M src/editor/map/map_context.cpp
    M src/game_board.cpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/lobby_data.cpp
    M src/gui/widgets/minimap.cpp
    M src/map/map.cpp
    M src/map/map.hpp
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  Move terrain_type_data pointer handling directly to gamemap

Drops the ctor argument from gamemap. I checked editor_map, and while it was creating its own terrain_type_data object,
it was using the same data as in the game_config_manager, so there's little point in not simply using the gcm's ttd
object in all cases. If the GCM singleton is null, a dummy object is created. Should cover the unit tests case.

This also removes the game_config_view arguments from the editor_map ctors since they're no longer needed.


Compare: https://github.com/wesnoth/wesnoth/compare/028f291c94f4...75e9d8a0f1eb



More information about the Commits mailing list