[wesnoth-commits] [wesnoth/wesnoth] 95dc1f: Teambuilder: big cleanup
Charles Dang
noreply at github.com
Sun Jan 3 17:55:58 UTC 2021
Branch: refs/heads/master
Home: https://github.com/wesnoth/wesnoth
Commit: 95dc1f994dc733833f3f6ac1dd541e631e57f088
https://github.com/wesnoth/wesnoth/commit/95dc1f994dc733833f3f6ac1dd541e631e57f088
Author: Charles Dang <exodia339 at gmail.com>
Date: 2021-01-03 (Sun, 03 Jan 2021)
Changed paths:
M src/game_state.cpp
M src/teambuilder.cpp
M src/teambuilder.hpp
Log Message:
-----------
Teambuilder: big cleanup
* Moved definition to the header
* Code formatting
* Removed global create_team_builder, build_team_stage_one, and build_team_stage_two functions in favor of calling the class members directly
* Stop using shared_ptrs in game_state and instead use vector::emplace
* Cleaned up includes
Commit: 3f40a8374c15196dc98da54f05ee7f0f30bca7b6
https://github.com/wesnoth/wesnoth/commit/3f40a8374c15196dc98da54f05ee7f0f30bca7b6
Author: Charles Dang <exodia339 at gmail.com>
Date: 2021-01-03 (Sun, 03 Jan 2021)
Changed paths:
M src/menu_events.cpp
Log Message:
-----------
Fixup b3e77a6 (singleton use I missed)
Commit: 19d7fb6827c086aadc0346758ee0d6d5ec809548
https://github.com/wesnoth/wesnoth/commit/19d7fb6827c086aadc0346758ee0d6d5ec809548
Author: Charles Dang <exodia339 at gmail.com>
Date: 2021-01-04 (Mon, 04 Jan 2021)
Changed paths:
M src/game_state.cpp
M src/teambuilder.hpp
Log Message:
-----------
Teambuilder: fixed a well-hidden bug involving this class being copyable
See comments for info. The space reserve in game_state isn't strictly necessary to fix this
(the move constructor was enough, but I figured might as well).
Commit: 3e26cba47514b2507bebfe1b44404f42dbb41739
https://github.com/wesnoth/wesnoth/commit/3e26cba47514b2507bebfe1b44404f42dbb41739
Author: Charles Dang <exodia339 at gmail.com>
Date: 2021-01-04 (Mon, 04 Jan 2021)
Changed paths:
M src/game_state.cpp
M src/teambuilder.cpp
M src/teambuilder.hpp
Log Message:
-----------
Teambuilder: only pass in the necessary team
Commit: 6306e1da664e1f8f684a7cc47dbbfe59051f83fb
https://github.com/wesnoth/wesnoth/commit/6306e1da664e1f8f684a7cc47dbbfe59051f83fb
Author: Charles Dang <exodia339 at gmail.com>
Date: 2021-01-04 (Mon, 04 Jan 2021)
Changed paths:
M data/core/terrain-graphics.cfg
M data/core/terrain-graphics/new-macros.cfg
Log Message:
-----------
Merge branch 'master' of github.com:wesnoth/wesnoth into master
Compare: https://github.com/wesnoth/wesnoth/compare/4ca64655cb4b...6306e1da664e
More information about the Commits
mailing list