[wesnoth-commits] [wesnoth/wesnoth] 5242fa: Removed redundant calls to game_launcher::clear_lo...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5242fa370ad9f670e1013e2ebc20e35365affa46
      https://github.com/wesnoth/wesnoth/commit/5242fa370ad9f670e1013e2ebc20e35365affa46
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M src/gui/dialogs/title_screen.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Removed redundant calls to game_launcher::clear_loaded_game

Calling game_launcher::load_game already cleared the loaded data if present unconditionally.


  Commit: 7d4e5d559566d589ba97d85fd8977a45d3ed3b5f
      https://github.com/wesnoth/wesnoth/commit/7d4e5d559566d589ba97d85fd8977a45d3ed3b5f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M src/wesnoth.cpp

  Log Message:
  -----------
  Fixed game possibly attempting to load in an error state

I'm not sure in what case game_launcher::load_game would return false here (I don't know if any of the exceptions
it catches can even be thrown from that code, for instance), but if for some reason that happens we don't want to
continue loading.


  Commit: 8b6def9678608758e953f185d83b7e0c3c4c26c5
      https://github.com/wesnoth/wesnoth/commit/8b6def9678608758e953f185d83b7e0c3c4c26c5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M src/game_launcher.cpp
    M src/game_launcher.hpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Game Launcher: renamed is_loading to has_load_data for clarity


Compare: https://github.com/wesnoth/wesnoth/compare/d9680a906c91...8b6def967860