[wesnoth-commits] [wesnoth/wesnoth] 1a1c62: Game Launcher: made clear_loaded_game and start_we...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1a1c629721c68b692e239f1c196d8b6a22970916
      https://github.com/wesnoth/wesnoth/commit/1a1c629721c68b692e239f1c196d8b6a22970916
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M src/game_launcher.hpp

  Log Message:
  -----------
  Game Launcher: made clear_loaded_game and start_wesnothd private

Also properly deleted the copy constructor and assignment operators.


  Commit: ca00ca27fbe35fadebcf8609735ebec5d93ea75c
      https://github.com/wesnoth/wesnoth/commit/ca00ca27fbe35fadebcf8609735ebec5d93ea75c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/game_launcher.cpp
    M src/game_launcher.hpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Game Launcher: used a scoped enum for mp_mode (renamed from mp_selection)


  Commit: 36bd3b262c1c3bb03c367270f82da5f416518fb6
      https://github.com/wesnoth/wesnoth/commit/36bd3b262c1c3bb03c367270f82da5f416518fb6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/game_launcher.cpp

  Log Message:
  -----------
  Game Launcher: made play_multiplayer return true on success

So far this return value isn't actually really used for anything, but it's better to have it
return true on success than false in all cases (including error conditions).


  Commit: 3932a11239395922a85d42345bddeae9ed51211f
      https://github.com/wesnoth/wesnoth/commit/3932a11239395922a85d42345bddeae9ed51211f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/wesnoth.cpp

  Log Message:
  -----------
  Removed redundant titlescreen control blocks in MP cases

No need to continue since we're already at the end of the loop. Regardless of the return value,
we want to loop again, in which case break handles that just fine.


Compare: https://github.com/wesnoth/wesnoth/compare/a4711ebad971...3932a1123939