[wesnoth-commits] [wesnoth/wesnoth] 22ab2e: HTTT: add wmllint: recognize Kalenz Delfador Konra...

[Andrey Bienkowski]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 22ab2eca92c5be4a91dd6cce9397ff8807f43442
      https://github.com/wesnoth/wesnoth/commit/22ab2eca92c5be4a91dd6cce9397ff8807f43442
  Author: Andrey Bienkowski <hexagonrecursion at gmail.com>
  Date:   2021-01-19 (Tue, 19 Jan 2021)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg

  Log Message:
  -----------
  HTTT: add wmllint: recognize Kalenz Delfador Konrad Li'sar

wmllint tries to detect errors such as a scenario referencing the unit by id before it is introduced by via [recall], [unit] etc.
The definition of "before" wmllint wants to check is chronological: "does an event that introduces a unit happen before an event that references it?",
but the current implementation cheats by simply checking if the definition textually precedes the reference.

22_Return_to_Wesnoth contains two prestart events. The first prestart event defines an event that triggers on turn 4. The second prestart event introduces Kalenz, Delfador and Li'sar.
I could merge the prestart events and reorder the code to avoid the wmllint error, but since it does not actually make the code easier to read I chose a less disruptive option of simply adding "wmllint: recognize".