[wesnoth-commits] [wesnoth/wesnoth] f8e58f: VS: specify C17 for C code

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f8e58f06257aacb585a64ae560bf9b26b4e1f0e8
      https://github.com/wesnoth/wesnoth/commit/f8e58f06257aacb585a64ae560bf9b26b4e1f0e8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M projectfiles/VC16/campaignd.vcxproj
    M projectfiles/VC16/liblua.vcxproj
    M projectfiles/VC16/wesnoth.vcxproj
    M projectfiles/VC16/wesnothd.vcxproj
    M projectfiles/VC16/wesnothlib.vcxproj

  Log Message:
  -----------
  VS: specify C17 for C code


  Commit: 52db6a92fc0f8ce68cb27040564f019dd0f41e94
      https://github.com/wesnoth/wesnoth/commit/52db6a92fc0f8ce68cb27040564f019dd0f41e94
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/global.hpp

  Log Message:
  -----------
  Removed explicit STDC99 define on MSVC

We compile Lau as C++ code anyway.


  Commit: 5df29bf9e67efc61cb01eb647f4efdb4871b1f92
      https://github.com/wesnoth/wesnoth/commit/5df29bf9e67efc61cb01eb647f4efdb4871b1f92
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/ai/actions.cpp
    M src/desktop/version.cpp
    M src/editor/controller/editor_controller.cpp
    M src/game_initialization/multiplayer.cpp
    M src/global.hpp
    M src/gui/auxiliary/iterator/walker_grid.cpp
    M src/gui/auxiliary/iterator/walker_tree_node.cpp
    M src/gui/auxiliary/iterator/walker_widget.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/message.cpp
    M src/play_controller.cpp
    M src/scripting/lua_common.cpp
    M src/serialization/parser.cpp
    M src/serialization/tokenizer.cpp

  Log Message:
  -----------
  Used [[fallthrough]] directly


  Commit: a1cb45dc2d26fe187e494c1a389f9212ca916977
      https://github.com/wesnoth/wesnoth/commit/a1cb45dc2d26fe187e494c1a389f9212ca916977
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/game_initialization/depcheck.cpp
    M src/game_initialization/depcheck.hpp

  Log Message:
  -----------
  Fixed build with /std:c++latest

`requires` is a reserved keyword in C++20 related to the new Concepts stuff, so you can't have a function
named that. Also renamed `conflicts` to `does_conflict` for consistency with the new `does_require`.


  Commit: b713de3d85b2a57eccbe913a0cb8c61d19adfd90
      https://github.com/wesnoth/wesnoth/commit/b713de3d85b2a57eccbe913a0cb8c61d19adfd90
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/spirit_po/catalog.hpp
    M src/spirit_po/default_plural_forms_expressions.hpp
    M src/spirit_po/exceptions.hpp
    M src/spirit_po/po_message.hpp

  Log Message:
  -----------
  Updated spirit-po from source

Applies (refs to :
* https://github.com/garbageslam/spirit-po/commit/4a72a9f0efc084762566f7fa8ead07a0586dd2d0 (we had !=, upstream used >, so I went with the latter)
* https://github.com/garbageslam/spirit-po/commit/4cf2d589e98e99d504e11a8b789cd94458714929 (catalog.hpp only)
* https://github.com/garbageslam/spirit-po/commit/fac4caa4d01f0fefbc88db6c3518454dc3ff2dde

This also fixes builds with /std:c++latest on MSVC. Seems that last commit which fixed things on
GCC9 also fixes thing on MSVC. Not entirely sure why it breaks in C++20 mode where it didn't before,
but potentially something to do with the default constructor and the new concepts stuff.


  Commit: a04f6d25644a54fff21c31aacdd6371911129ec8
      https://github.com/wesnoth/wesnoth/commit/a04f6d25644a54fff21c31aacdd6371911129ec8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/commandline_argv.cpp
    M src/desktop/open.cpp
    M src/filesystem.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/server/campaignd/server.cpp
    M src/tests/test_config.cpp

  Log Message:
  -----------
  Replaced UNUSED with [[maybe_unused]] where applicable


  Commit: 204d3b4254022b17a9c97d1c6881175a095e0752
      https://github.com/wesnoth/wesnoth/commit/204d3b4254022b17a9c97d1c6881175a095e0752
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/ai/formula/function_table.cpp
    M src/commandline_argv.cpp
    M src/config.hpp
    M src/config_attribute_value.hpp
    M src/exceptions.hpp
    M src/formula/function.cpp
    M src/gettext.cpp
    M src/gui/auxiliary/iterator/walker_grid.cpp
    M src/gui/auxiliary/iterator/walker_tree_node.cpp
    M src/gui/auxiliary/iterator/walker_widget.cpp
    M src/hash.hpp
    M src/lexical_cast.hpp
    M src/log.cpp
    M src/log.hpp
    M src/lua_jailbreak_exception.hpp
    M src/scripting/lua_terrainfilter.cpp
    M src/scripting/lua_terrainmap.cpp
    M src/scripting/push_check.hpp
    M src/sdl/surface.hpp
    M src/serialization/tokenizer.cpp
    M src/units/abilities.cpp
    M src/utils/general.hpp
    M src/utils/make_enum.hpp
    M src/utils/name_generator.hpp
    M src/utils/scope_exit.hpp
    M src/utils/shared_reference.hpp

  Log Message:
  -----------
  Cleaned up global.hpp includes


  Commit: 7311b19d4d24ca0f54a309e033f2a767d56faeb4
      https://github.com/wesnoth/wesnoth/commit/7311b19d4d24ca0f54a309e033f2a767d56faeb4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-23 (Sat, 23 Jan 2021)

  Changed paths:
    M src/ai/composite/aspect.hpp
    M src/events.cpp
    M src/game_data.cpp
    M src/gui/core/event/dispatcher_private.hpp
    M src/gui/core/event/handler.cpp
    M src/quit_confirmation.cpp
    A src/utils/ranges.hpp
    M src/whiteboard/highlighter.cpp
    M src/whiteboard/mapbuilder.cpp

  Log Message:
  -----------
  Added utils::reversed_view

This is a wrapper around either std::views::reversed (C++20) or boost::adaptors::reverse (anything else).


Compare: https://github.com/wesnoth/wesnoth/compare/a8a3bedc46d5...7311b19d4d24