[wesnoth-commits] [wesnoth/wesnoth] 6c13d7: Fixup e555e0681db1e8

[Celtic Minstrel]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6c13d7f1038c3947b0c4d822a453ac107c1ea287
      https://github.com/wesnoth/wesnoth/commit/6c13d7f1038c3947b0c4d822a453ac107c1ea287
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M src/gui/dialogs/statistics_dialog.cpp

  Log Message:
  -----------
  Fixup e555e0681db1e8

I think this is an MSVC bug, but revert the change from e555e0681db1e8 that isn't building on Windows.


  Commit: dc180c7db0299bba26894933181326827bec8ff6
      https://github.com/wesnoth/wesnoth/commit/dc180c7db0299bba26894933181326827bec8ff6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M src/ai/lua/core.cpp

  Log Message:
  -----------
  Lua AI: The recalculate move map functions don't return anything so why do they claim to return 1 value!?


  Commit: 9c2689ac9eb302a283e88bdac936468d86040345
      https://github.com/wesnoth/wesnoth/commit/9c2689ac9eb302a283e88bdac936468d86040345
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/ai/lua/stdlib.lua
    M src/ai/lua/core.cpp

  Log Message:
  -----------
  Lua AI: Move the deprecation messages to Lua so that the deprecated functions get nulled out with --strict-lua


  Commit: c1304fb4418cabe06f5ea8bfbace261ababb8535
      https://github.com/wesnoth/wesnoth/commit/c1304fb4418cabe06f5ea8bfbace261ababb8535
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/lua/location_set.lua

  Log Message:
  -----------
  Lua: Add location_set.of_raw to ease working with AI functions that return raw location sets


  Commit: 0b309a0d6a1e44f308ec0842e5c9b6f6b3ff51fd
      https://github.com/wesnoth/wesnoth/commit/0b309a0d6a1e44f308ec0842e5c9b6f6b3ff51fd
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/core/_main.cfg
    R data/lua/as_text.lua
    A data/lua/core/as_text.lua

  Log Message:
  -----------
  Lua API: Move wesnoth.as_text into core

This means it's now usable in map generation or plugin scripts.


  Commit: d04bd2bf5d2ad932ca9bb3203f4ff9f91411e261
      https://github.com/wesnoth/wesnoth/commit/d04bd2bf5d2ad932ca9bb3203f4ff9f91411e261
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_common.cpp
    M src/scripting/lua_common.hpp

  Log Message:
  -----------
  Lua API: Add a named tuple idiom, used mainly for locations

This should fix the issue introduced in 5a9c24c4e79d624e34aa475949a4aa49b1984322

I also spotted a couple more cases missed in the prior commit.


  Commit: c6f4e8db2815883cdf6f745e7c5ae2b98e9a8dab
      https://github.com/wesnoth/wesnoth/commit/c6f4e8db2815883cdf6f745e7c5ae2b98e9a8dab
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/lua/wml-utils.lua

  Log Message:
  -----------
  Lua API: Use string indexing here


  Commit: 695eb8356d3125a8a6e8ffabb1434b7564b5a0a3
      https://github.com/wesnoth/wesnoth/commit/695eb8356d3125a8a6e8ffabb1434b7564b5a0a3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/lua/location_set.lua

  Log Message:
  -----------
  Lua API: Better error checking when converting a location set to a WML variable


  Commit: 9ad2a8d2a0be2ca18af03dfb56779d4d6b0d7c8b
      https://github.com/wesnoth/wesnoth/commit/9ad2a8d2a0be2ca18af03dfb56779d4d6b0d7c8b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  Lua API: find_reach now accepts ignore_teleport=false without a viewing_side

It now issues a Lua warning, but then continues as if ignore_teleport=true had been passed.


  Commit: f5de3cca180c63e8abf4f0677934a783a012bccc
      https://github.com/wesnoth/wesnoth/commit/f5de3cca180c63e8abf4f0677934a783a012bccc
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M data/lua/location_set.lua

  Log Message:
  -----------
  Lua API: Add a mode argument to locaton_set:to_wml_var

It has the same semantics as the mode in wml_utils.vwriter.init.


Compare: https://github.com/wesnoth/wesnoth/compare/e555e0681db1...f5de3cca180c