[wesnoth-commits] [wesnoth/wesnoth] 630cbd: Fix custom synced commands not changing the AI gam...

[mattsc]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 630cbdca353a709db5dbaf7435894a8fdb214d18
      https://github.com/wesnoth/wesnoth/commit/630cbdca353a709db5dbaf7435894a8fdb214d18
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2021-07-09 (Fri, 09 Jul 2021)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Fix custom synced commands not changing the AI game state

The old ai.synced_command function always set the AI-context game state to changed when executing such a command. This was inadvertently omitted when the implementation was changed to invoke_synced_command in fef953a4. While custom synced commands may or may not change the game state and the engine has no means of determining this correctly in all cases (meaning that neither behavior is technically wrong), the fact that the behavior was changed should be considered a bug. This commit changes it back to how it was before fef953a4.


  Commit: 93d501d9a47f2556475baa71e96a3717ce294eab
      https://github.com/wesnoth/wesnoth/commit/93d501d9a47f2556475baa71e96a3717ce294eab
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2021-07-09 (Fri, 09 Jul 2021)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Merge pull request #5943 from mattsc/gamestate_synced_command

Fix custom synced commands not changing the AI game state


Compare: https://github.com/wesnoth/wesnoth/compare/69e4b5395dad...93d501d9a47f