[wesnoth-commits] [wesnoth/wesnoth] 050feb: Add-ons manager: Fix bugs that return to the title...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 050feb623b19e360c024b584ab1e9452bd6e22b4
      https://github.com/wesnoth/wesnoth/commit/050feb623b19e360c024b584ab1e9452bd6e22b4
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-05-30 (Sun, 30 May 2021)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Add-ons manager: Fix bugs that return to the title screen with an "Invalid WML" message

This fixes two specific causes of #3059, where code assumes that all parts of
the add-ons manager's UI are accessible, an assumption that fails when the
dialog uses a stacked widget to handle small window sizes.

It would be better to redesign the C++ for this dialog, but a quick workaround
for the observed issues is much easier.

* Fixes #5810, triggered by using the version drop-down in small-screen mode.
* Adds a workaround for keyboard input changing the selected add-on on small screens.


  Commit: 5d5f62e31e13948f005f82bd0ca3c6f0fb983bdd
      https://github.com/wesnoth/wesnoth/commit/5d5f62e31e13948f005f82bd0ca3c6f0fb983bdd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-06-01 (Tue, 01 Jun 2021)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Merge pull request #5820 from stevecotton/addons_two_panel

Add-ons manager: Fix bugs that return to the title screen with an "Invalid WML" message


Compare: https://github.com/wesnoth/wesnoth/compare/08bfe41b9e1a...5d5f62e31e13