[wesnoth-commits] [wesnoth/wesnoth] ce67e7: Fix a misleading (and grammatically poor) log message

[Celtic Minstrel]

  Branch: refs/heads/wfl_crash_fix
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ce67e7831b8fbcab9b3a450231a5d215d1f9d4f9
      https://github.com/wesnoth/wesnoth/commit/ce67e7831b8fbcab9b3a450231a5d215d1f9d4f9
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-03-07 (Sun, 07 Mar 2021)

  Changed paths:
    M src/formula/debugger.cpp

  Log Message:
  -----------
  Fix a misleading (and grammatically poor) log message


  Commit: 714f411a6894a69fb5fe81dc6772f1c2971ff5dc
      https://github.com/wesnoth/wesnoth/commit/714f411a6894a69fb5fe81dc6772f1c2971ff5dc
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-03-13 (Sat, 13 Mar 2021)

  Changed paths:
    M src/ai/default/attack.cpp
    M src/ai/default/contexts.hpp
    M src/ai/formula/ai.cpp
    M src/ai/formula/ai.hpp
    M src/ai/formula/callable_objects.cpp
    M src/ai/formula/callable_objects.hpp
    M src/ai/formula/candidates.cpp
    M src/ai/formula/stage_side_formulas.cpp
    M src/ai/formula/stage_unit_formulas.cpp
    M src/formula/callable.hpp
    M src/formula/callable_fwd.hpp
    M src/formula/callable_objects.cpp
    M src/formula/callable_objects.hpp
    M src/formula/formula.cpp
    M src/formula/function.cpp
    M src/formula/function.hpp
    M src/formula/variant_value.cpp
    M src/formula/variant_value.hpp
    M src/gui/core/canvas.cpp
    M src/image_modifications.cpp
    M src/scripting/lua_formula_bridge.cpp
    M src/scripting/lua_terrainfilter.cpp
    M src/terrain/filter.cpp
    M src/units/filter.cpp

  Log Message:
  -----------
  WFL: Fix a crash if a formula object goes out of scope before the formula has been fully evaluated

This removes the old system that was supposed to prevent this from happening and replaces it with enable_shared_from_this coupled with a system to automatically copy the object if it's not already tracked by a shared_ptr (which usually means it was allocated on the stack).


  Commit: 1bdcdb11ed1718737a1156d425d9de8e0f585e24
      https://github.com/wesnoth/wesnoth/commit/1bdcdb11ed1718737a1156d425d9de8e0f585e24
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-03-13 (Sat, 13 Mar 2021)

  Changed paths:
    M data/ai/micro_ais/engines/lurker_moves.fai

  Log Message:
  -----------
  Lurker FAI: map(x, self) is exactly the same as just self

This caused the crash fixed in the previous commit. Although the crash is fixed, it's still stupid and we shouldn't do it.


Compare: https://github.com/wesnoth/wesnoth/compare/ce67e7831b8f%5E...1bdcdb11ed17