[wesnoth-commits] [wesnoth/wesnoth] abc328: Rename functions managing special weapons to impro...

[newfrenchy83]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: abc328e39faf90fb43f77f5253eb3cc463f82c80
      https://github.com/wesnoth/wesnoth/commit/abc328e39faf90fb43f77f5253eb3cc463f82c80
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp
    M src/units/udisplay.cpp

  Log Message:
  -----------
  Rename functions managing special weapons to improve readability for engine devellopper

When I was looking at the special weapons extension to [abilities] tags, I didn't understand the concept of lists at first, until someone added the .append function to add a list to a list. other, but I kept the names I used for the functions. Now that this work is completed, I would like the function calls to find their original names (get_specials and get_special_bool) among other things to clarify the reading for a developer.


  Commit: eaa4e92fed481541be72a3c1d5cdb3eb6aafd5c5
      https://github.com/wesnoth/wesnoth/commit/eaa4e92fed481541be72a3c1d5cdb3eb6aafd5c5
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  replace "_old" by "_without_abilities"


  Commit: 1bb895c0d5353d24650aa9ff62b7357cec86bc7d
      https://github.com/wesnoth/wesnoth/commit/1bb895c0d5353d24650aa9ff62b7357cec86bc7d
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  other simplification for readibility


  Commit: 92ad8abbf4b5860b248a99260a00f2c05a64ae58
      https://github.com/wesnoth/wesnoth/commit/92ad8abbf4b5860b248a99260a00f2c05a64ae58
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  revert last modification and use specials_and_abilities in name of global function


  Commit: 56cfa32a434e145a18149b6e3392ab084f0f0fe3
      https://github.com/wesnoth/wesnoth/commit/56cfa32a434e145a18149b6e3392ab084f0f0fe3
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  fix a forget in attack.cpp


  Commit: 6b40f8a537de083dbc75ca16c5dde94607341eff
      https://github.com/wesnoth/wesnoth/commit/6b40f8a537de083dbc75ca16c5dde94607341eff
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  rename get_..._bool method to has_.. method


  Commit: da83861b79bf8d6b41f3dc394fc2d625b97cd145
      https://github.com/wesnoth/wesnoth/commit/da83861b79bf8d6b41f3dc394fc2d625b97cd145
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  rename has_special_and_abilities to has_special_or_abilities


  Commit: 31b053f1f0888c3bf9e9dfd3b1e42de7e71ec31b
      https://github.com/wesnoth/wesnoth/commit/31b053f1f0888c3bf9e9dfd3b1e42de7e71ec31b
  Author: newfrenchy83 <eric.belleux at gmail.com>
  Date:   2021-03-26 (Fri, 26 Mar 2021)

  Changed paths:
    M src/actions/attack.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  change has_special_and_abilities to has_special_and_ability


Compare: https://github.com/wesnoth/wesnoth/compare/847b70ab4c36...31b053f1f088