[wesnoth-commits] [wesnoth/wesnoth] 3167e3: WFL: Deal with the side fiasco by deprecating it

[Celtic Minstrel]

  Branch: refs/heads/wfl_tod
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3167e3a085d7207597a7285d1438d15b17ff1529
      https://github.com/wesnoth/wesnoth/commit/3167e3a085d7207597a7285d1438d15b17ff1529
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-05-23 (Sun, 23 May 2021)

  Changed paths:
    M src/formula/callable_objects.cpp

  Log Message:
  -----------
  WFL: Deal with the side fiasco by deprecating it

When you have a unit object, "side" starts at 0. When you have a terrain object, "owner" starts at 0 (or -1 for an unowned tile). When you have a side object, "side" starts at 1.

This deprecates all those and adds "side_number" (or "owner_side" for terrain) instead which always starts at 1.


  Commit: 4dc4ee40858db099dedd710b45450b32fbe65234
      https://github.com/wesnoth/wesnoth/commit/4dc4ee40858db099dedd710b45450b32fbe65234
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-05-23 (Sun, 23 May 2021)

  Changed paths:
    M src/formula/function_gamestate.cpp

  Log Message:
  -----------
  WFL: Add functions to get the time of day bonus

tod_bonus: accounts for inherent terrain lighting and unit illumination effects
base_tod_bonus: ignores these effects

Both take an optional location and an optional turn number. With a location, time areas are taken into account. With a turn number, you can check what the bonus will be iin the future, or what it was in the past.

Closes #5776


  Commit: 7145c19acd0eb25b4ca337d03969bb9f44f265f4
      https://github.com/wesnoth/wesnoth/commit/7145c19acd0eb25b4ca337d03969bb9f44f265f4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-05-23 (Sun, 23 May 2021)

  Changed paths:
    M src/formula/function_gamestate.cpp

  Log Message:
  -----------
  whitespace fixes


  Commit: 969d83dbb939aadddc9d434e9acfdb1538c3b1be
      https://github.com/wesnoth/wesnoth/commit/969d83dbb939aadddc9d434e9acfdb1538c3b1be
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2021-05-23 (Sun, 23 May 2021)

  Changed paths:
    M src/formula/callable_objects.cpp

  Log Message:
  -----------
  WFL: Add a convenient way to get the terrain a unit is standing on


Compare: https://github.com/wesnoth/wesnoth/compare/105112c7f488...969d83dbb939