[wesnoth-commits] [wesnoth/wesnoth] 69ee81: Remove the fast path of [modify_unit] (#6223)

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 69ee817955632cc2d9d7c3b98d8dd7624fb81a8b
      https://github.com/wesnoth/wesnoth/commit/69ee817955632cc2d9d7c3b98d8dd7624fb81a8b
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-11-05 (Fri, 05 Nov 2021)

  Changed paths:
    M data/lua/wml/modify_unit.lua
    A data/test/scenarios/test_modify_unit.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Remove the fast path of [modify_unit] (#6223)

Always use the "slow path", because it stores and unstores the unit, triggering
the desired side effects of unstoring a unit.

Fixes issue #5133, and tests that with the new unit test.

Fixes bug #4978, that changing the facing wasn't updating the display.

This corresponds to 1.16's commit 13c5d8a96ead8d2a7f0435f60b8ec7f7e0af0972,
that commit merely disabled the fast path to be a minimal change.