[wesnoth-commits] [wesnoth/wesnoth] dfe792: wesnothd: remove catch clause for std::exception

[Sergey Popov]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dfe7925449ccc5362f076dbf26bc29dfe91ce293
      https://github.com/wesnoth/wesnoth/commit/dfe7925449ccc5362f076dbf26bc29dfe91ce293
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnothd: remove catch clause for std::exception

it loses too much information about the exception


  Commit: 7c086f1f74ac2cd775a4876e7d8e17dbad8e5cc0
      https://github.com/wesnoth/wesnoth/commit/7c086f1f74ac2cd775a4876e7d8e17dbad8e5cc0
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/game.hpp
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnothd: avoid trying to remove destructed players from games during stack unwinding


  Commit: 9d19f13ba2020e8cece86c9cd491538210972b84
      https://github.com/wesnoth/wesnoth/commit/9d19f13ba2020e8cece86c9cd491538210972b84
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/common/server_base.cpp

  Log Message:
  -----------
  wesnothd: don't let exceptions stop asio's event loop

Generally if we catch exception but continue the loop the player
associated with it would be automatically disconnected either due to
socket_ptr going out of scope or scope_exit calling remove_player().


  Commit: 2f477b37d3a53ed152c6bef3428c02d910030bbc
      https://github.com/wesnoth/wesnoth/commit/2f477b37d3a53ed152c6bef3428c02d910030bbc
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/game.cpp

  Log Message:
  -----------
  wesnothd: check for possible null optional in error message


  Commit: 74ae8e4dc4d8d80426c8008ac497f71ef6492817
      https://github.com/wesnoth/wesnoth/commit/74ae8e4dc4d8d80426c8008ac497f71ef6492817
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnoth: use async_shutdown() instead of shutdown()


  Commit: d7c2816c98f96723989edb37d840a8eda42e1bce
      https://github.com/wesnoth/wesnoth/commit/d7c2816c98f96723989edb37d840a8eda42e1bce
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp
    M src/server/wesnothd/server.hpp

  Log Message:
  -----------
  wesnothd: Fix server crash if client is autokicked by registered login


  Commit: 8b5a0b1fa26532b8ca505c0ce3cfa97c03c0ad0c
      https://github.com/wesnoth/wesnoth/commit/8b5a0b1fa26532b8ca505c0ce3cfa97c03c0ad0c
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/common/server_base.cpp

  Log Message:
  -----------
  servers: add dedicated catch for boost::system::system_error

To get message from error_code instead of what()


  Commit: 5a7488e53205c1131e222b1b5f9e9f53d9cf6504
      https://github.com/wesnoth/wesnoth/commit/5a7488e53205c1131e222b1b5f9e9f53d9cf6504
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnothd: properly shutdown tls connection without leaving clients hanging


  Commit: 7670dd3403acd67e932c22ca1d75c63b4270a449
      https://github.com/wesnoth/wesnoth/commit/7670dd3403acd67e932c22ca1d75c63b4270a449
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnothd: fix crash when yielding after kick in is_login_allowed()


  Commit: e5c7e7eb28e5d3c51577b7cdaf460451ecf48ad0
      https://github.com/wesnoth/wesnoth/commit/e5c7e7eb28e5d3c51577b7cdaf460451ecf48ad0
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/network_asio.cpp

  Log Message:
  -----------
  Add extra debug info when verifying TLS cert in the client


  Commit: cb9bb5f5474a507948f060359da2e9a0f56261ed
      https://github.com/wesnoth/wesnoth/commit/cb9bb5f5474a507948f060359da2e9a0f56261ed
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/network_asio.cpp

  Log Message:
  -----------
  Fixed UB due to debug log side effects not evaluating


  Commit: 81f958778a3a6c089f85e6a19ea3a3fbde76d9f3
      https://github.com/wesnoth/wesnoth/commit/81f958778a3a6c089f85e6a19ea3a3fbde76d9f3
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/game.cpp

  Log Message:
  -----------
  wesnothd: avoid potential use of null optional when handling surrender


  Commit: dc8780bc45db03e97831ec7d9d6aa45f44adc4d5
      https://github.com/wesnoth/wesnoth/commit/dc8780bc45db03e97831ec7d9d6aa45f44adc4d5
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M src/server/wesnothd/server.cpp

  Log Message:
  -----------
  wesnothd: prevent spurious log messages about unknown data

due to control falling through to handle_player_in_game() after message
was already handled.


Compare: https://github.com/wesnoth/wesnoth/compare/dbf22b54dbce...dc8780bc45db