[wesnoth-commits] [wesnoth/wesnoth] 57cfcf: Switch to hard-coded colours instead of relying on...

[Wedge009]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 57cfcf87d79de2f6c06a27f1938021971d7310e0
      https://github.com/wesnoth/wesnoth/commit/57cfcf87d79de2f6c06a27f1938021971d7310e0
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M src/help/help_impl.cpp
    M src/reports.cpp
    M src/units/attack_type.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Switch to hard-coded colours instead of relying on pango names (resolves #4348).

* Pango changed its definition of 'green' in version 1.32.2 to align with CSS specifications (see #4348 for details).
* This change focuses only on instances of '<span color="green">', leaving instances of named colours that don't use 'green'.
* Problem: Cannot use this approach with '<format>' (at least not that I'm currently aware) so it breaks time-of-day bonus colour consistency.


  Commit: 8285cac7f5fa182dcfae5b592626e601042eefe5
      https://github.com/wesnoth/wesnoth/commit/8285cac7f5fa182dcfae5b592626e601042eefe5
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M src/gui/dialogs/formula_debugger.cpp

  Log Message:
  -----------
  Switch to hard-coded colours for formula debugger as well.


Compare: https://github.com/wesnoth/wesnoth/compare/4c9e016fa319...8285cac7f5fa