[wesnoth-commits] [wesnoth/wesnoth] 3439d0: Fix deprecation of [advancefrom], mark as already ...

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3439d069d077d3dd63978f6b9253fd3c048fbcfe
      https://github.com/wesnoth/wesnoth/commit/3439d069d077d3dd63978f6b9253fd3c048fbcfe
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2022-02-02 (Wed, 02 Feb 2022)

  Changed paths:
    M src/game_config_manager.cpp

  Log Message:
  -----------
  Fix deprecation of [advancefrom], mark as already removed

The existing code searched for `[units][advancefrom]` instead of
`[unit_type][advancefrom]`, so wasn't triggering. It was planned
for removal in 1.17, so simply mark it as already-removed in 1.15.3.

The deprecation warning is shown on stdout/stderr, but not in the
in-game UI, so it's generally not visible to players. I think it
would be better if it was visible, but OTOH it's something that's
easy for someone to check all add-ons for with a simple grep.

(cherry picked from commit f2fa807e6107c63aa9b38f36e5ad8a8fcfacf9a9)