[wesnoth-commits] [wesnoth/wesnoth] 6a72b2: Add-ons manager: handle the selected add-on changi...

[Steve Cotton]

  Branch: refs/heads/1.16
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6a72b2e5114619e7736de97d47a1407254f8fa8a
      https://github.com/wesnoth/wesnoth/commit/6a72b2e5114619e7736de97d47a1407254f8fa8a
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2022-02-08 (Tue, 08 Feb 2022)

  Changed paths:
    M changelog.md
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Add-ons manager: handle the selected add-on changing in small-screen mode

Fix another instance of issue #3059, where code assumes that all parts of the
add-ons manager's UI are accessible, an assumption that fails when the dialog
uses a stacked widget to handle small window sizes.

The up and down arrow keys select the previous or next add-on in the list,
even when the small-window layout is hiding the list. That feels like a feature
rather than a bug, as it's useful and an understandable UX; however it needs
the fix in this commit so that on_addon_select() doesn't throw an exception
and close the dialog. The new code is the same as the fix that 050feb623b
applied to on_selected_version_change, traversing the stacked widget to get the
info.