[wesnoth-commits] [wesnoth/wesnoth] a4e8ac: Only try to activate required addons after loading...

[Pentarctagon]

  Branch: refs/heads/1.16
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a4e8ac339eabcd94f337ad809d10de2a70272ba7
      https://github.com/wesnoth/wesnoth/commit/a4e8ac339eabcd94f337ad809d10de2a70272ba7
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2022-01-01 (Sat, 01 Jan 2022)

  Changed paths:
    M src/game_classification.cpp
    M src/game_config_manager.cpp
    M src/game_config_manager.hpp

  Log Message:
  -----------
  Only try to activate required addons after loading all addons present.

The current issue is that, when loading a replay that requires addons from the main menu, it's checking for which addons can be enabled with game_classification.active_addons(...) before it reloads the cache to contain addons (such as eras) that are behind the #ifdef MULTIPLAYER define. It is of course impossible to find addon content before it has been loaded, which results in things like OOS errors due to unknown unit types.

Fixes #6283