[wesnoth-commits] [wesnoth/wesnoth] 327997: Remove gui/auxiliary/filter.hpp and unused include...
Charles Dang
noreply at github.com
Mon Mar 14 20:36:16 UTC 2022
Branch: refs/heads/master
Home: https://github.com/wesnoth/wesnoth
Commit: 32799739608b9c6eedb5ff791f6d1229452551de
https://github.com/wesnoth/wesnoth/commit/32799739608b9c6eedb5ff791f6d1229452551de
Author: Steve Cotton <steve at octalot.co.uk>
Date: 2022-03-09 (Wed, 09 Mar 2022)
Changed paths:
M projectfiles/CodeBlocks-SCons/wesnoth.cbp
M projectfiles/CodeBlocks/tests.cbp
M projectfiles/CodeBlocks/wesnoth.cbp
R src/gui/auxiliary/filter.hpp
M src/gui/dialogs/addon/manager.cpp
M src/gui/dialogs/addon/manager.hpp
M src/gui/widgets/listbox.cpp
Log Message:
-----------
Remove gui/auxiliary/filter.hpp and unused includes of pane.hpp
Remove filter.hpp, which wasn't included by any file, and relied on
pane.hpp indirectly via one of the lines removed in this commit. The sorting
functionality seems to have moved into pane.cpp when matrix.hpp was added.
Note: there are two other unrelated `filter.hpp` files.
Header pane.hpp is only used by matrix.hpp, pane.cpp, and window_builder.cpp;
the class is also used via a forward-declaration in window.hpp, which friends
it, allowing a call to window::layout_linked_widgets. The class is also made
accessible via REGISTER_WIDGET.
Part of #6540.
Commit: f1a94200421766bcc9004c5fb1468b39434cdb1c
https://github.com/wesnoth/wesnoth/commit/f1a94200421766bcc9004c5fb1468b39434cdb1c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2022-03-14 (Mon, 14 Mar 2022)
Changed paths:
M projectfiles/CodeBlocks-SCons/wesnoth.cbp
M projectfiles/CodeBlocks/tests.cbp
M projectfiles/CodeBlocks/wesnoth.cbp
R src/gui/auxiliary/filter.hpp
M src/gui/dialogs/addon/manager.cpp
M src/gui/dialogs/addon/manager.hpp
M src/gui/widgets/listbox.cpp
Log Message:
-----------
Merge pull request #6558 from stevecotton/cleanup_pane_includes
Remove gui/auxiliary/filter.hpp and unused includes of pane.hpp
Compare: https://github.com/wesnoth/wesnoth/compare/39c9ca03da75...f1a942004217
More information about the Commits
mailing list