[Commits] [wesnoth/wesnoth] 050085: Improve code formatting.

GitHub noreply at github.com
Sun Apr 6 13:11:00 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 050085622037ba7d064057d8de9a1920831ecf4d
      https://github.com/wesnoth/wesnoth/commit/050085622037ba7d064057d8de9a1920831ecf4d
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Improve code formatting.


  Commit: 1ad329c114de7c58ddc29462f034300dee1f084a
      https://github.com/wesnoth/wesnoth/commit/1ad329c114de7c58ddc29462f034300dee1f084a
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Use a SDL_Surface* instead of a surface.

The management of the surface is done in this class, this will probably
conflict with the surface management in the surface class.


  Commit: bf20045ecdfc1bc33a52f3f3e486a5da66f468a2
      https://github.com/wesnoth/wesnoth/commit/bf20045ecdfc1bc33a52f3f3e486a5da66f468a2
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp

  Log Message:
  -----------
  Initialise a member in the initialiser list.


  Commit: 3afebbb988d7af6a409182092adbb813a1064aed
      https://github.com/wesnoth/wesnoth/commit/3afebbb988d7af6a409182092adbb813a1064aed
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Remove the keep_surface parameter.

Whether or not the surface should be kept depends on the access mode of
the texture. It is possible to update a static image, but that is not
intended to be used, so remove the part of the API that makes it easier
to do.


  Commit: 210eb6a7a092074e21da8a99edbb9ccc38f06189
      https://github.com/wesnoth/wesnoth/commit/210eb6a7a092074e21da8a99edbb9ccc38f06189
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp

  Log Message:
  -----------
  Improve exception path.

When the exception is thrown from the body of the constructor the
destructor is called, so no need to manage the lifetime of the
source_surface_ before throwing an exception.


  Commit: abe73ab915b755b78bd1460e2da0bc395dcfe127
      https://github.com/wesnoth/wesnoth/commit/abe73ab915b755b78bd1460e2da0bc395dcfe127
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp

  Log Message:
  -----------
  Check the result of SDL_UpdateTexture.


  Commit: 345fc7f9de5025753318b8e49b89787d4b0ae4d3
      https://github.com/wesnoth/wesnoth/commit/345fc7f9de5025753318b8e49b89787d4b0ae4d3
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Change order of parameters in constructor.

The order of the access mode is now more consistent with the other
constructor.


  Commit: e1d054d6ff5df6ed1dfeb566fb38bb1eb9e294a2
      https://github.com/wesnoth/wesnoth/commit/e1d054d6ff5df6ed1dfeb566fb38bb1eb9e294a2
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Improve documentation.


  Commit: 6d4545df783c71c7da84beb4b4a04ec4c7151e33
      https://github.com/wesnoth/wesnoth/commit/6d4545df783c71c7da84beb4b4a04ec4c7151e33
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp

  Log Message:
  -----------
  Change destruction order.

The order now is the reverse of the construction, probably doesn't
matter, but feels more like the normal constructor/destructor
creation/destruction order.


  Commit: f583f616f041b5176d67049e0c2705aac07ffa33
      https://github.com/wesnoth/wesnoth/commit/f583f616f041b5176d67049e0c2705aac07ffa33
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-06 (Sun, 06 Apr 2014)

  Changed paths:
    M src/sdl/texture.cpp
    M src/sdl/texture.hpp

  Log Message:
  -----------
  Merge branch 'SDL_Texture_polishing'

Various minor changes polishing the image load code for textures.


Compare: https://github.com/wesnoth/wesnoth/compare/f0519651222e...f583f616f041


More information about the Commits mailing list