[Commits] [wesnoth/wesnoth] cec331: Use 'faction' and 'gender' attributes to provide d...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cec331c11b4d85f7f37b127d0373e14a76b6d475
      https://github.com/wesnoth/wesnoth/commit/cec331c11b4d85f7f37b127d0373e14a76b6d475
  Author: Andrius Silinskas <silinskas.andrius at gmail.com>
  Date:   2014-04-10 (Thu, 10 Apr 2014)

  Changed paths:
    M src/flg_manager.cpp
    M src/flg_manager.hpp

  Log Message:
  -----------
  Use 'faction' and 'gender' attributes to provide default values in MP Create.

Before this, 'faction' and 'gender' were not used if 'force_lock_settings'
wasn't set to 'yes'. This resulted in inconsistent behaviour between the
mentioned two attributes and 'type' attribute. When 'type' was set, the relevant
leader was always selected by default.

This partially fixes bugs #21753 and #20562. To properly address them, it might
be needed to add 'faction_lock', 'type_lock' and 'gender_lock' attributes so
that UMC authors would have a way to actually lock these selections without
using 'force_lock_settings' if they don't want to.