[Commits] [wesnoth/wesnoth] 851ef4: Fix comment typos.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 851ef445ab168a5e50ce0bac54a8bec9409faac4
      https://github.com/wesnoth/wesnoth/commit/851ef445ab168a5e50ce0bac54a8bec9409faac4
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/gui/dialogs/campaign_selection.hpp

  Log Message:
  -----------
  Fix comment typos.


  Commit: ef1e0e199b714846980ecae5bce3cff317106dea
      https://github.com/wesnoth/wesnoth/commit/ef1e0e199b714846980ecae5bce3cff317106dea
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/gui/dialogs/campaign_selection.hpp

  Log Message:
  -----------
  Initialise all members.

Issue found by cppcheck.


  Commit: 5acb30af5fe6960370ce12cf0eb89f93e120450a
      https://github.com/wesnoth/wesnoth/commit/5acb30af5fe6960370ce12cf0eb89f93e120450a
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/game_preferences_display.cpp

  Log Message:
  -----------
  Pre instead of post increment a variable.

Issue found by cppcheck.


  Commit: 2f780b96bebb59fe8b0ce26754e28954495b52e7
      https://github.com/wesnoth/wesnoth/commit/2f780b96bebb59fe8b0ce26754e28954495b52e7
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Replace a increment loop with std::advance.

The code was flagged by cppcheck, due to the post increment.


  Commit: e8116089a2714b57b814540a62f1294d61215978
      https://github.com/wesnoth/wesnoth/commit/e8116089a2714b57b814540a62f1294d61215978
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Pre instead of post increment a variable.

Issue found by cppcheck.


  Commit: b90fd14075a0efd79f92c574bd86242304730855
      https://github.com/wesnoth/wesnoth/commit/b90fd14075a0efd79f92c574bd86242304730855
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Pre instead of post increment a variable.

Issue found by cppcheck.


  Commit: e381f564c5c7ae402d678870ce277777b7355ba9
      https://github.com/wesnoth/wesnoth/commit/e381f564c5c7ae402d678870ce277777b7355ba9
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Pre instead of post increment a variable.

Issue found by cppcheck.


  Commit: 4ca1afc4131292cc94bd95f3ead424a6123e8e28
      https://github.com/wesnoth/wesnoth/commit/4ca1afc4131292cc94bd95f3ead424a6123e8e28
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Use empty() instead of comparing size() with 0.

Issue found by cppcheck.


  Commit: 35f0d7245469e90c83507f9f7431fadfec525025
      https://github.com/wesnoth/wesnoth/commit/35f0d7245469e90c83507f9f7431fadfec525025
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Use empty() instead of comparing size() with 0.

Issue found by cppcheck.


  Commit: b099e7c752d24898065d7b6d201e3b996c48f7b8
      https://github.com/wesnoth/wesnoth/commit/b099e7c752d24898065d7b6d201e3b996c48f7b8
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/map_label.cpp

  Log Message:
  -----------
  Use dtor + placement new in assignment operator.

The change was used to simplify the code. A member was not copied and
that was noticed by cppcheck.


  Commit: 80d49c6011d3fb32dd8294328f5c32ec1798c7fa
      https://github.com/wesnoth/wesnoth/commit/80d49c6011d3fb32dd8294328f5c32ec1798c7fa
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/help.cpp

  Log Message:
  -----------
  Use a variable as const ref instead of const.

Issue found by cppcheck.


  Commit: 0840f7627d05d42562fc9945a61117e31b39fa54
      https://github.com/wesnoth/wesnoth/commit/0840f7627d05d42562fc9945a61117e31b39fa54
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/race.cpp

  Log Message:
  -----------
  Limit variable scope.

Issue found by cppcheck.


  Commit: a3c51d2f81ae17b3157911db30ed1ad67abd6223
      https://github.com/wesnoth/wesnoth/commit/a3c51d2f81ae17b3157911db30ed1ad67abd6223
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/replay_controller.cpp

  Log Message:
  -----------
  Remove an unneeded helper variable.

There was a cppcheck warning, that the scope of has_end_turn could be
reduced. Removing the variable makes the even simpler.


  Commit: 2b943e2967b4374a0b5bdc5dd14062fbf3959bcd
      https://github.com/wesnoth/wesnoth/commit/2b943e2967b4374a0b5bdc5dd14062fbf3959bcd
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/serialization/unicode.cpp

  Log Message:
  -----------
  Limit variable scope.

Issue found by cppcheck.


  Commit: 734f1be224c94edefa10244fe7561ab3886c0890
      https://github.com/wesnoth/wesnoth/commit/734f1be224c94edefa10244fe7561ab3886c0890
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-04-12 (Sat, 12 Apr 2014)

  Changed paths:
    M src/game_preferences_display.cpp
    M src/gui/dialogs/campaign_selection.hpp
    M src/help.cpp
    M src/map_label.cpp
    M src/playturn_network_adapter.cpp
    M src/race.cpp
    M src/replay_controller.cpp
    M src/serialization/unicode.cpp

  Log Message:
  -----------
  Merge branch 'cppcheck'

Fixes several issues found by cppcheck, or issues found while reviewing
the issues found by cppcheck.


Compare: https://github.com/wesnoth/wesnoth/compare/4c1c487fec3d...734f1be224c9