[Commits] [wesnoth/wesnoth] b643d1: fixup party full bell

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b643d184fdede228b4811409a8e02e983645f8bc
      https://github.com/wesnoth/wesnoth/commit/b643d184fdede228b4811409a8e02e983645f8bc
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M src/multiplayer_connect.cpp
    M src/multiplayer_connect_engine.cpp

  Log Message:
  -----------
  fixup party full bell

the party full bell code is moved back to the engine, and is
based on checking whether processing the most recent message
has made it now possible to start the game. this seems to be
the simplest logic that will do the right thing, it will now
make the bell play whenever the "I'm ready" button is active

this also addresses bug #21910.

note: the reason we don't check the "silent" flag is that it
causes the sound not to be played in some circumstances where
it should. multiplayer_connect_engine currently returns
value "true" for silent (the second part of result) in all
cases except when a player has been successfully assigned to
a side, in which case it is false. depending on the status of
allow_changes, that might be a time that we want to play the
"ready to start" bell.


  Commit: fe38d3064f9aca5fdb024a9599249a2a6b917654
      https://github.com/wesnoth/wesnoth/commit/fe38d3064f9aca5fdb024a9599249a2a6b917654
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M changelog

  Log Message:
  -----------
  update changelog


Compare: https://github.com/wesnoth/wesnoth/compare/2e0a133ef3d1...fe38d3064f9a