[Commits] [wesnoth/wesnoth] 7d8620: fix a typo in comment

GitHub noreply at github.com
Sat Jul 5 00:28:26 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7d8620b6c8d5716d6eb0a09fe76e92e1b335146e
      https://github.com/wesnoth/wesnoth/commit/7d8620b6c8d5716d6eb0a09fe76e92e1b335146e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-04 (Fri, 04 Jul 2014)

  Changed paths:
    M src/unit_filter.cpp

  Log Message:
  -----------
  fix a typo in comment


  Commit: 7f3bb10e222900743f45a63464d6f7357d2cfb95
      https://github.com/wesnoth/wesnoth/commit/7f3bb10e222900743f45a63464d6f7357d2cfb95
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-04 (Fri, 04 Jul 2014)

  Changed paths:
    M src/unit_filter.cpp

  Log Message:
  -----------
  add lazy parsing of comma separated lists to unit_filter

The old code seemed to desperately want to avoid calling split
on large lists of strings repeatedly, however it did this again
and again for every unit. The new implementation remembers the old
splits for the next time the filter is applied, but makes sure
only to split them if the old code would have split them.


Compare: https://github.com/wesnoth/wesnoth/compare/c9d05ff61bd4...7f3bb10e2229


More information about the Commits mailing list