[Commits] [wesnoth/wesnoth] 5490a5: Simplify --resolution error handling

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5490a55a3b3d795ebdc6677f9ceaffb9b5139030
      https://github.com/wesnoth/wesnoth/commit/5490a55a3b3d795ebdc6677f9ceaffb9b5139030
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp

  Log Message:
  -----------
  Simplify --resolution error handling

Reuse the boost::program_options::error class (which we already catch in
main()) instead of throwing a std::string, and simplify the throwing
logic accordingly.

There is no need to provide incredibly verbose error messages since the
user is expected to be able to read --help or the man page to get here
in the first place.


  Commit: 64af83f4f09c0d66be4758cfce971461cbaea244
      https://github.com/wesnoth/wesnoth/commit/64af83f4f09c0d66be4758cfce971461cbaea244
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp

  Log Message:
  -----------
  Simplify tuple command line arguments error handling

Reuse the boost::program_options::error class (which we already catch in
main()) instead of throwing a std::string, and simplify the throwing
logic accordingly.

There is no need to provide incredibly verbose error messages since the
user is expected to be able to read --help or the man page to get here
in the first place.


Compare: https://github.com/wesnoth/wesnoth/compare/76a7e47225b7...64af83f4f09c