[Commits] [wesnoth/wesnoth] e7eb08: fix bug 22086, by storing map data correctly in sa...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e7eb08d0cd2d57b55bf084b669fbeec8d283db33
      https://github.com/wesnoth/wesnoth/commit/e7eb08d0cd2d57b55bf084b669fbeec8d283db33
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-10 (Thu, 10 Jul 2014)

  Changed paths:
    M src/dialogs.cpp
    M src/game_controller.cpp
    M src/gamestatus.cpp
    M src/savegame.cpp

  Log Message:
  -----------
  fix bug 22086, by storing map data correctly in savegame summaries

The bug was that minimap previews for save games were not appearing,
or that the wrong ones were appearing.

It seems that because of more relics from this commit / related,

https://github.com/wesnoth/wesnoth/commit/c17d84b12

the savegame summaries generated by "extract savegame summary" were
bugged and didn't store the map data correctly. This bug wasn't
obvious because the save game load dialog tries to scavenge what
ever the current game config is for map data if it can't find this,
but all of the saveindex data was being generated incorrectly.

After this commit all the save files seem to work correctly,
except for start-of-scenario saves for reasons that aren't clear
to me, and which I think is a separate issue. (In that case,
something is going wrong with the game_config lookup process most
likely.)

This only appears to fix the bug for normal saves, autosaves, and
replay saves.


  Commit: 71d867a01f58d3250d0dd66a23de5b3d706cfb02
      https://github.com/wesnoth/wesnoth/commit/71d867a01f58d3250d0dd66a23de5b3d706cfb02
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-10 (Thu, 10 Jul 2014)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M players_changelog

  Log Message:
  -----------
  update changelogs


Compare: https://github.com/wesnoth/wesnoth/compare/d65d03c23116...71d867a01f58