[Commits] [wesnoth/wesnoth] d1bfbe: fix a logic error in help code

GitHub noreply at github.com
Fri Jul 18 18:43:45 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d1bfbee006f0e9980e859e1557db890eb1330a1f
      https://github.com/wesnoth/wesnoth/commit/d1bfbee006f0e9980e859e1557db890eb1330a1f
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-18 (Fri, 18 Jul 2014)

  Changed paths:
    M src/help.cpp

  Log Message:
  -----------
  fix a logic error in help code

This case analsis was meant to catch +,- symbols at the end of the
alias string and drop them, but it should have been checking if the
last change occurred at end - 1 rather than end.


  Commit: 957d0327a4d2e0f1b49251f005cedcaeaad9cd97
      https://github.com/wesnoth/wesnoth/commit/957d0327a4d2e0f1b49251f005cedcaeaad9cd97
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-18 (Fri, 18 Jul 2014)

  Changed paths:
    M src/help.cpp

  Log Message:
  -----------
  fixup implementation of terrain behavior strings

We don't need to make a recursive call for the second part of the
group, only the first part of the group, since we know that there
are no more changes that happen in the second part. This prevents
adding unnecessary parentheses.


  Commit: 32cad50800f83782b279364a72df53fba1d9be3e
      https://github.com/wesnoth/wesnoth/commit/32cad50800f83782b279364a72df53fba1d9be3e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-18 (Fri, 18 Jul 2014)

  Changed paths:
    M src/configure_engine.cpp

  Log Message:
  -----------
  Merge branch 'master' of git://github.com/wesnoth/wesnoth


Compare: https://github.com/wesnoth/wesnoth/compare/16301034ec7c...32cad50800f8


More information about the Commits mailing list