[Commits] [wesnoth/wesnoth] 0e9f18: gui2/tgamestate_inspector: Use write() function fo...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0e9f18d8ebd2394a1ea0d51ac41c63761739deef
      https://github.com/wesnoth/wesnoth/commit/0e9f18d8ebd2394a1ea0d51ac41c63761739deef
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-09 (Mon, 09 Jun 2014)

  Changed paths:
    M changelog
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  gui2/tgamestate_inspector: Use write() function for printing WML objects

The write() function from the WML parser is a dedicated WML
serialization mechanism that is also used to write saved games and such,
and thus it will output WML in the same format that the game would
normally use. The config::debug() method we were using here before,
instead, only implements a simplified strategy that will not produce
valid multiline attribute values, for example, or include any textdomain
directives applicable to the contents.

If we are to have a way to copy the inspect window's contents, it should
prove far more convenient for coders to see the generated WML in the
same format as it would normally be saved to disk.


  Commit: eab3e6fb646fda8cc6101a3e568c86c2b17b707f
      https://github.com/wesnoth/wesnoth/commit/eab3e6fb646fda8cc6101a3e568c86c2b17b707f
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-09 (Mon, 09 Jun 2014)

  Changed paths:
    M changelog
    M data/gui/default/window/gamestate_inspector.cfg
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  gui2/tgamestate_inspector: Add a button to copy contents to clipboard

This copies the contents of the main display area to clipboard. The
button currently lacks a tooltip because the tooltip causes map labels
to glitch through the dialog when displayed (noticeable in e.g. the test
scenario). I'll file a bug for this issue later using a (commented-out)
line introduced by this commit as a test case.


  Commit: 03021c04828a87f389a93a437a516f7d1a5d2a8a
      https://github.com/wesnoth/wesnoth/commit/03021c04828a87f389a93a437a516f7d1a5d2a8a
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-09 (Mon, 09 Jun 2014)

  Changed paths:
    M changelog
    M data/gui/default/window/gamestate_inspector.cfg
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  Merge branch 'feature/inspect-copy-paste'


Compare: https://github.com/wesnoth/wesnoth/compare/51a2c0443fd8...03021c04828a