[Commits] [wesnoth/wesnoth] 821fee: gui2/tgamestate_inspector: Use write() function fo...

GitHub noreply at github.com
Wed Jun 11 03:07:16 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 821feef111de34dd2663d90bef03aa2b5ba7d016
      https://github.com/wesnoth/wesnoth/commit/821feef111de34dd2663d90bef03aa2b5ba7d016
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-10 (Tue, 10 Jun 2014)

  Changed paths:
    M changelog
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  gui2/tgamestate_inspector: Use write() function for printing WML objects

The write() function from the WML parser is a dedicated WML
serialization mechanism that is also used to write saved games and such,
and thus it will output WML in the same format that the game would
normally use. The config::debug() method we were using here before,
instead, only implements a simplified strategy that will not produce
valid multiline attribute values, for example, or include any textdomain
directives applicable to the contents.

If we are to have a way to copy the inspect window's contents, it should
prove far more convenient for coders to see the generated WML in the
same format as it would normally be saved to disk.


  Commit: 6a56da5f0f60558f0c15206a92b91a612a4dc5da
      https://github.com/wesnoth/wesnoth/commit/6a56da5f0f60558f0c15206a92b91a612a4dc5da
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-10 (Tue, 10 Jun 2014)

  Changed paths:
    M changelog
    M data/gui/default/window/gamestate_inspector.cfg
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  gui2/tgamestate_inspector: Add a button to copy contents to clipboard

This copies the contents of the main display area to clipboard. The
button currently lacks a tooltip because the tooltip causes map labels
to glitch through the dialog when displayed (noticeable in e.g. the test
scenario). I'll file a bug for this issue later using a (commented-out)
line introduced by this commit as a test case.


  Commit: 4d338f52e872321aa7a7176c1f33fd4c0da8b260
      https://github.com/wesnoth/wesnoth/commit/4d338f52e872321aa7a7176c1f33fd4c0da8b260
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-10 (Tue, 10 Jun 2014)

  Changed paths:
    M changelog
    M data/gui/default/window/gamestate_inspector.cfg
    M src/gui/dialogs/gamestate_inspector.cpp

  Log Message:
  -----------
  Merge branch 'backport/1.12/inspect-copy-paste' into 1.12


Compare: https://github.com/wesnoth/wesnoth/compare/e47ebac43a75...4d338f52e872


More information about the Commits mailing list