[Commits] [wesnoth/wesnoth] 74e123: delete duplicated set_team fcn

GitHub noreply at github.com
Sun Jun 15 02:08:00 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 74e1230b9af8b0f0387c5d0eb0f8201784a73d1e
      https://github.com/wesnoth/wesnoth/commit/74e1230b9af8b0f0387c5d0eb0f8201784a73d1e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M src/game_display.cpp
    M src/game_display.hpp

  Log Message:
  -----------
  delete duplicated set_team fcn

game_display and display versions of set_team were identical, in
header and in implementation, so we simply delete the game_display
one, as a strict refactor.


  Commit: 926effb41a06337c27442200d97d01429b15446e
      https://github.com/wesnoth/wesnoth/commit/926effb41a06337c27442200d97d01429b15446e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/game_display.cpp

  Log Message:
  -----------
  fixup segfaults in replay viewer

After this commit e4eb0a3ede83ee338994708ebd48257627b47242 the
replay viewer would segfault during prestart events. However, it
turns out that nothing in the replay viewer, or in that commit,
was directly causing the segault. Instead, the display object
was holding dangling pointers for no reason, when it could have.
been simply computing the correct value (very cheaply). We clean
up the code in the display objects to fix the segfault.


  Commit: 4cd8eb9f52e87957b6f0c353a40591ce663ce804
      https://github.com/wesnoth/wesnoth/commit/4cd8eb9f52e87957b6f0c353a40591ce663ce804
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
    M src/map_location.cpp

  Log Message:
  -----------
  Merge branch 'master' of git://github.com/wesnoth/wesnoth


Compare: https://github.com/wesnoth/wesnoth/compare/342ff4f718d6...4cd8eb9f52e8


More information about the Commits mailing list