[Commits] [wesnoth/wesnoth] 2ffdcb: gui2/tslider: Add minimal variant without a text l...

GitHub noreply at github.com
Thu Jun 19 06:40:39 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2ffdcb7e45713a0d3ffb25a1af611bfaeefc433c
      https://github.com/wesnoth/wesnoth/commit/2ffdcb7e45713a0d3ffb25a1af611bfaeefc433c
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    A data/gui/default/widget/slider_minimal.cfg

  Log Message:
  -----------
  gui2/tslider: Add minimal variant without a text label

The default variant's text label is both inflexible in content (can't
customize the format for non-edge values) and layout (reserves way more
space than it needs at a time for its text label, often resulting in
huge horizontal gaps between a slider and an adjacent widget). This
makes it unsuitable for use in gui2::tchat_log.

This new minimal variant will be wired into gui2::tchat_log next.


  Commit: eee57afbd2f2918c3d5a7bd476b6f6a8e2b9f53d
      https://github.com/wesnoth/wesnoth/commit/eee57afbd2f2918c3d5a7bd476b6f6a8e2b9f53d
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M data/gui/default/window/chat_log.cfg
    M src/gui/dialogs/chat_log.cpp

  Log Message:
  -----------
  gui2/tchat_log: Use a separate proper label for the page number text

This replaces the page number slider with a "minimal" variant slider and
an adjacent label widget whose text we enter manually.

The label format is "<PAGE>/<COUNT>" and it's untranslatable. Hopefully
this shouldn't cause any localization issues since it's all numbers and
we currently can't use alternative numeral systems anyway.

I'm leaving the page slider's maximum_value_label attribute intact just
in case this needs to be reverted later, since it's going into the 1.12
branch too.


Compare: https://github.com/wesnoth/wesnoth/compare/c997732df16d...eee57afbd2f2


More information about the Commits mailing list