[Commits] [wesnoth/wesnoth] ce33ba: NR: Refactor the White Magi respawn location findi...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ce33ba394a689b173ed3cc0f933fde262a18c21d
      https://github.com/wesnoth/wesnoth/commit/ce33ba394a689b173ed3cc0f933fde262a18c21d
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-21 (Sat, 21 Jun 2014)

  Changed paths:
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg

  Log Message:
  -----------
  NR: Refactor the White Magi respawn location finding code into a macro

This bit was subject to a particularly bad case of code copy-pasting
when the only real variable is the id of the first respawn hub
candidate.

Added a statement to clear the respawn_hub WML variable after running
the code since it's never used again afterwards.


  Commit: da8f3c824cc5ddb78a975455048cca341fd8cc94
      https://github.com/wesnoth/wesnoth/commit/da8f3c824cc5ddb78a975455048cca341fd8cc94
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-21 (Sat, 21 Jun 2014)

  Changed paths:
    M changelog
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg
    M players_changelog

  Log Message:
  -----------
  NR: Search for White Magi respawn locs only within map edges (bug #22097)

Without this, the engine may match map borders and send the respawnee
back to the player's recall list as those count as invalid locations
like "recall","recall".


Compare: https://github.com/wesnoth/wesnoth/compare/45e8753cc58f...da8f3c824cc5