[Commits] [wesnoth/wesnoth] 741b54: Fix for halos glitching through locations that bec...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 741b54c463099235803d334794fd247deeed8019
      https://github.com/wesnoth/wesnoth/commit/741b54c463099235803d334794fd247deeed8019
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-03-19 (Wed, 19 Mar 2014)

  Changed paths:
    M changelog
    M players_changelog
    M src/halo.cpp

  Log Message:
  -----------
  Fix for halos glitching through locations that become shrouded after rendering

Halos are never rendered for shrouded locations, but they are still
unrendered for them. A long-standing issue with [item] halos resulting
from this is that a halo that gets rendered to the screen at least once
for an unshrouded location later causes glitches if that location is
manually shrouded afterwards.

This can be avoided by not unrendering halos for shrouded locations. I
believe this solution makes sense because halos for shrouded locations
are never rendered first, and if the location is shrouded later on, the
display code will redraw the affected locations and overlay shroud on
top, causing the halo object's unrender buffer to become hopelessly
obsolete.