[Commits] [wesnoth/wesnoth] f19fd1: fixup [command] [move] implementation

GitHub noreply at github.com
Sat May 17 01:26:03 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f19fd113f53ee4446b98d4521e230c5c1edbcebc
      https://github.com/wesnoth/wesnoth/commit/f19fd113f53ee4446b98d4521e230c5c1edbcebc
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-16 (Fri, 16 May 2014)

  Changed paths:
    M src/synced_commands.cpp

  Log Message:
  -----------
  fixup [command] [move] implementation

The move implementation used a function from map_location.cpp,
parse_location_range. This has the consequence that if the move tag
has mismatched numbers of entries for x and y, it is not reported
as an error and instead some truly bizarre, although not "undefined"
behavior ensues. Since this has obvious potential to conceal bugs
and no obvious benefit, I have changed this to a more sane
implementation. See chat log today with gfgtdf for full details.





More information about the Commits mailing list