[Commits] [wesnoth/wesnoth] 7247cb: bad_lexical_cast derives from std::exception

GitHub noreply at github.com
Sun May 18 02:16:39 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7247cb4e2ef6b4847b2dc59900f46773a5e872c4
      https://github.com/wesnoth/wesnoth/commit/7247cb4e2ef6b4847b2dc59900f46773a5e872c4
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/lexical_cast.hpp

  Log Message:
  -----------
  bad_lexical_cast derives from std::exception


  Commit: a7b81ea2e27df44f9af0cd5686f0ba0a7d680f70
      https://github.com/wesnoth/wesnoth/commit/a7b81ea2e27df44f9af0cd5686f0ba0a7d680f70
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    M src/game_events/action_wml.cpp
    M src/map_location.hpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  catch bad lexical casts (from parsing map locations from configs)


  Commit: 2ed0908eb59530730b92164bbb73379a938f49d2
      https://github.com/wesnoth/wesnoth/commit/2ed0908eb59530730b92164bbb73379a938f49d2
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    A src/tests/test_map_location.cpp

  Log Message:
  -----------
  add map_location characterization tests

There is a compiler option to generate the expected output set for
the current build, see test_map_location.cpp


  Commit: 42ce06bd22a5895d8a2645f7265431849c57fb9a
      https://github.com/wesnoth/wesnoth/commit/42ce06bd22a5895d8a2645f7265431849c57fb9a
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/synced_commands.cpp

  Log Message:
  -----------
  refactor synced_commands [move] to use read_locations, not reimpl.


  Commit: d0c7e9b6f6af8785a015d7f5ad12c1163da6703b
      https://github.com/wesnoth/wesnoth/commit/d0c7e9b6f6af8785a015d7f5ad12c1163da6703b
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/tests/test_map_location.cpp

  Log Message:
  -----------
  fixup test_map_location.cpp

Was checking vector sum commutativity twice, replaced with an
anticommutativity test for vector_difference.


  Commit: 7370daa0da475192d0460af059d54d9d43e5b898
      https://github.com/wesnoth/wesnoth/commit/7370daa0da475192d0460af059d54d9d43e5b898
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/map_location.cpp
    M src/synced_commands.cpp

  Log Message:
  -----------
  Fix map_locations.cpp read_locations function

read_locations will no longer silently process a mismatched list of
x and y integers as a valid path, instead it will throw a
bad_lexical_cast. gfgtdf and I discussed on irc, we don't believe
that this will break save or replay compatibility, and it could
potentially help to catch possible OOS bugs in the future. I am
currently passing all my C++ and WML unit tests with this commit.

This commit also changes the [command] [move] handler over to use
this function directly without checking for mismatched lists, so
if this commit is reverted that function will still work correctly.


  Commit: 8f03e00e81c79b5edf62abbd1519b2dd18c2eb20
      https://github.com/wesnoth/wesnoth/commit/8f03e00e81c79b5edf62abbd1519b2dd18c2eb20
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M changelog
    M src/dialogs.cpp
    M src/editor/editor_controller.cpp
    M src/help.cpp
    M src/help.hpp
    M src/reports.cpp

  Log Message:
  -----------
  Merge branch '1.12' of git://github.com/wesnoth/wesnoth into 1.12


Compare: https://github.com/wesnoth/wesnoth/compare/ced6d9e15f1c...8f03e00e81c7


More information about the Commits mailing list