[Commits] [wesnoth/wesnoth] 38211c: fixup end of scenario saves

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 38211c1036bae1b1c303cd4bb8242f3de2754133
      https://github.com/wesnoth/wesnoth/commit/38211c1036bae1b1c303cd4bb8242f3de2754133
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  fixup end of scenario saves


  Commit: 1a7d358e39ec6725041018ff739daab3e13d02cc
      https://github.com/wesnoth/wesnoth/commit/1a7d358e39ec6725041018ff739daab3e13d02cc
  Author: Chris Beck <beck.ct at gmail.com>
  Date:   2014-05-30 (Fri, 30 May 2014)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  Merge pull request #174 from cbeck88/fixup_end_of_scenario_saves

fixup end of scenario saves

iceiceice writes: does anyone know why we have this line?
https://github.com/wesnoth/wesnoth/blob/master/src/play_controller.cpp#L752
it causes end of scenario saves to be stripped of all units
my theory is that it was for some point in time before carryover was implemented properly
i propose to remove it in 1.12 and master

AI0867 writes: See commit aa2cf7d.
Looks like the carryover refactoring might have made it do the opposite of what it used to.


Compare: https://github.com/wesnoth/wesnoth/compare/18a0bc3b77ab...1a7d358e39ec