[Commits] [wesnoth/wesnoth] 02a31a: Remove superfluous 'sane' flag from version_info

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 02a31a5b8945fd6dff235157e317660ae048a89c
      https://github.com/wesnoth/wesnoth/commit/02a31a5b8945fd6dff235157e317660ae048a89c
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-04-03 (Fri, 03 Apr 2015)

  Changed paths:
    M src/addon/state.cpp
    M src/campaign_server/campaign_server.cpp
    M src/game_config.cpp
    M src/game_config_manager.cpp
    M src/game_initialization/multiplayer_lobby.cpp
    M src/mp_game_settings.cpp
    M src/savegame.cpp
    M src/tests/test_version.cpp
    M src/version.cpp
    M src/version.hpp

  Log Message:
  -----------
  Remove superfluous 'sane' flag from version_info

This also removes the accompanying version_info::not_sane_exception
exception type, as well as the version_info::good() method.

The flag is never naturally set to false during version_info
construction/parsing and actual invalid version numbers are always some
variation of "0.0.0foo" once reserialized. The few cases in code where
the flag is forced to be false can be trivially adapted to not require
its existence. In effect, the associated exception was never thrown and
the good() method always returned true, save for the aforementioned
exceptions.

All in all, this was a preposterous waste of time and indentation
levels.


  Commit: 257fa2b3c3ffc9e273d214d691e6759f312ef4a3
      https://github.com/wesnoth/wesnoth/commit/257fa2b3c3ffc9e273d214d691e6759f312ef4a3
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-04-03 (Fri, 03 Apr 2015)

  Changed paths:
    M src/version.hpp

  Log Message:
  -----------
  Documentation improvements and declaration reordering for version_info

No actual code changes other than moving a couple of method declarations
around for readability.


Compare: https://github.com/wesnoth/wesnoth/compare/5c70bd2ffb85...257fa2b3c3ff