[Commits] [wesnoth/wesnoth] 5108fa: Fix version_info ctor calls expecting the sane par...

GitHub noreply at github.com
Tue Aug 18 06:58:42 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5108fa05adc41b0feec4bda21b5699bee4ebc678
      https://github.com/wesnoth/wesnoth/commit/5108fa05adc41b0feec4bda21b5699bee4ebc678
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-08-18 (Tue, 18 Aug 2015)

  Changed paths:
    M src/addon/manager.cpp
    M src/addon/state.cpp

  Log Message:
  -----------
  Fix version_info ctor calls expecting the sane parameter

The sane parameter was removed in commit
02a31a5b8945fd6dff235157e317660ae048a89c, but I did not realize that
`false` would still be implicitly cast to char and invoke the usual list
constructor.

Fix this by using the default constructor instead, which does what we
want sans removed parameter.

Note that this mistake and subsequent fix has no bearing on anything
other than code presentation because false and '\0' are the same value
and the three number values are 0 with the default ctor too.





More information about the Commits mailing list